Avatar

Please consider registering
guest

sp_LogInOut Log In sp_Registration Register

Register | Lost password?
Advanced Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 3 characters - maximum search word length is 84 characters

sp_Feed Topic RSS sp_TopicIcon
Sustain behaviour - DXSynth
Avatar
lppier
Member
Members
January 19, 2015 - 7:26 pm
Member Since: December 21, 2014
Forum Posts: 23
sp_UserOfflineSmall Offline

Hi Will,

The midi sustain works in a strange way, when I release the note and press sustain on my midi keyboard, it sustains.
When I let go of sustain and press down sustain again while the sound is in release, the note ramps up to the last sustain vol level.
Is this the intended sustain behaviour? For most synths I've tried the sustain seems to work only once in the entire adsr, once you release that's it. Granted, it's probably an easy fix, but is this intended?

Thanks.

Avatar
lppier
Member
Members
January 19, 2015 - 10:31 pm
Member Since: December 21, 2014
Forum Posts: 23
sp_UserOfflineSmall Offline

Turned out to be pretty simple to change the behaviour, commented the below code in doEnvelope()
But, is there a use case for such the original behaviour?

case release:
{
// --- if sustain pedal is down, override and return
// if(m_bSustainOverride)
// {
// m_dEnvelopeOutput = m_dSustainLevel;
// break;
// }
// else
// --- render value
m_dEnvelopeOutput = m_dReleaseOffset + m_dEnvelopeOutput*m_dReleaseCoeff;

// --- check go to next state
if(m_dEnvelopeOutput <= 0.0 || m_dReleaseTime_mSec <= 0.0)
{
m_dEnvelopeOutput = 0.0;
m_uState = off; // go to next state
break;
}
break;
}

Avatar
W Pirkle
Admin
January 22, 2015 - 10:52 pm
Member Since: January 29, 2017
Forum Posts: 470
sp_UserOfflineSmall Offline

Refer to the book regarding the way the DXSynth is different that all others in that it has no one specific Output EG connected to the DCA. The Sustain Override should only apply to EGs that are on the final output, and there is a flag you set to control this. So, when you hold the sustain pedal, only the output EG's should "stick" and the others should still be in motion. I think this may be what you are experiencing but you can double check that.

- Will

Forum Timezone: America/New_York

Most Users Ever Online: 152

Currently Online:
6 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

Skyler: 48

Derek: 46

Frodson: 45

Peter: 43

TheSmile: 43

clau_ste: 39

Chaes: 37

JimmyM: 33

Gwen: 32

jim: 27

Member Stats:

Guest Posters: 1

Members: 648

Moderators: 1

Admins: 4

Forum Stats:

Groups: 13

Forums: 40

Topics: 695

Posts: 2674

Newest Members:

oneday, Phelan Kane, audiocoder, agel, Makai, Abyz, Nonlinear, IgorVish, Arjuna, TomMilne

Moderators: W Pirkle: 470

Administrators: Tom: 74, JD Young: 80, Will Pirkle: 0, W Pirkle: 470